Skip to content

fix(keeper): repair CI tests and Docker build#21

Merged
abs2023 merged 1 commit into
devfrom
fix/ci-keeper-node24
May 26, 2026
Merged

fix(keeper): repair CI tests and Docker build#21
abs2023 merged 1 commit into
devfrom
fix/ci-keeper-node24

Conversation

@abs2023
Copy link
Copy Markdown
Contributor

@abs2023 abs2023 commented May 26, 2026

Summary

Fixes CI failures on dev after merging keeper infra (#20):

  • Keeper tests: PERPS_REPO / FUTURES_REPO in keeper-test.yml pointed at …/contracts, but artifacts.ts expects sibling repo roots (it appends contracts/artifacts/…). That produced double contracts/ paths and missing Multicall3 artifacts.
  • Deploy build: Docker pnpm install failed with ERR_PNPM_LOCKFILE_CONFIG_MISMATCH because patchedDependencies live in pnpm-workspace.yaml + patches/ but were not copied into the image.
  • Docker context: Keeper imported errSerializer from market-maker/ outside ./keeper build context — vendored into keeper/src/util/.
  • Node 24: FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 on keeper test + deploy workflows (runtime image already node:24-alpine; setup-node already 24).

Test plan

  • Keeper Tests workflow green on this PR
  • Deploy Collateral Margin Keeper build job green (deploy may still need env secrets on merge to dev)

Made with Cursor

Align PERPS_REPO/FUTURES_REPO with artifact loader (repo roots), copy pnpm
patches into the image, vendor errSerializer for keeper-only Docker context,
and opt GitHub Actions into Node 24 for action runtimes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@abs2023 abs2023 merged commit 2c0b4ac into dev May 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant